Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debugger] Assert when async debug a generic method #17727

Merged
merged 7 commits into from
Nov 13, 2019

Commits on Nov 5, 2019

  1. When we try to call a method to get the async_id to do an async debug…

    … and we are trying to do this in a generic method like this:
    
    async Task<T> ExecuteAsync_Broken<T>()
     {
                await Task.Delay(2);
                return default;
      }
    
    We need to inflate the generic type before call the method or we will get the error:  Could not execute the method because the containing type 'System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[T_REF]’, is not fully instantiated.
    
    Fixes mono#17549
    Fixes mono#17569
    thaystg committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    bec3050 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    905f4bf View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. adding unit test

    thaystg committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    1ddff3d View commit details
    Browse the repository at this point in the history
  2. Update mono/mini/debugger-agent.c

    Co-Authored-By: Aleksey Kliger (λgeek) <akliger@gmail.com>
    thaystg and lambdageek committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    2e279d5 View commit details
    Browse the repository at this point in the history
  3. Adding mono prefix.

    thaystg committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    f696f90 View commit details
    Browse the repository at this point in the history
  4. Moving mono_get_generic_context_from_stack_frame to debugger-engine b…

    …ecause debugger-agent is not used on wasm, causing a compilation error.
    thaystg committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    7dbe5e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Moving mono_get_generic_context_from_stack_frame back to mini-excepti…

    …on and the declaration is in mini.h
    thaystg committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    708739c View commit details
    Browse the repository at this point in the history