Override Environment.SpecialFolder.Personal with $HOME #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any port that writes to Environment.SpecialFolder.Personal during build or when running tests may end up with files outside of stage area that aren't cleaned up by the ports framework. The issue lies with Mono looking in /etc/passwd first and only if no entry found there in HOME. Patch based on discussion in mono#371 Obtained from: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193426
|
After looking at the history of gmisc-unix (and gpath before that), plus the fact that well known env vars should override system defaults, I believe this to be the right behavior. |
kumpera
added a commit
that referenced
this pull request
Jun 8, 2015
Override Environment.SpecialFolder.Personal with $HOME
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Override Environment.SpecialFolder.Personal with $HOME Commit migrated from mono/mono@aac7aed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any port that writes to Environment.SpecialFolder.Personal during build
or when running tests may end up with files outside of stage area that
aren't cleaned up by the ports framework. The issue lies with Mono
looking in /etc/passwd first and only if no entry found there in HOME.
Patch based on discussion in
#371
Obtained from: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193426