Fixes MemoryMappedFile related segfault with dnvm #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed MemoryMappedFile related code to use reference source MemoryMappedViewAccessor and MemoryMappedViewStream. This change was motivated by segmentations faults while dnmv code was calling a CoreFX class that uses reflection to call MemoryMappedFile code. Now that we are using more code from reference sources there should be no problem. Fixes #30741 and #30825.
Fixes segmentation fault when mono_mmap_open_handle is called with a null mapName argument. MemoryMappedFiles.CreateFromFile calls mono_mmap_open_handle, .NET implementation accepts a null mapName and CoreFX uses CreateFromFile with null mapName. Fixes #30825 and #30741.
|
Please merge this into master. It makes the latest mono code usable on i386. |
Commented out PointerOffset asserts because its value is always 0. Unlike .NET mono implementation creates MemoryMappedViews with no PointerOffset.
esdrubal
added a commit
that referenced
this pull request
Jun 16, 2015
Fixes MemoryMappedFile related segfault with dnvm
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fixes MemoryMappedFile related segfault with dnvm Commit migrated from mono/mono@7f3b76a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed MemoryMappedFile related code to use reference source
MemoryMappedViewAccessor and MemoryMappedViewStream.
This change was motivated by segmentations faults while dnmv code was
calling a CoreFX class that uses reflection to call MemoryMappedFile
code.
Now that we are using more code from reference sources there should be
no problem.
Fixes segmentation fault when mono_mmap_open_handle is called with a null mapName argument.
MemoryMappedFiles.CreateFromFile calls mono_mmap_open_handle, .NET implementation accepts a null mapName and CoreFX uses CreateFromFile with null mapName.
Fixes #30741 and #30825.