[mono] Implement Sse2.AddSaturate using LLVM #18793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
requested review from
imhameed,
lambdageek,
lewurm,
SamMonoRT and
vargaz
as code owners
monojenkins
force-pushed
the
sync-pr-32116-from-runtime
branch
from
eaf4c05
to
4179ed4
Compare
vargaz
approved these changes
Feb 11, 2020
Mono currently supports a limited subset of **Sse1**-**Sse42** intrinsics used only by CoreLib internally. So once a new API is used to optimize things there we also have to implement it in Mono. So it recently happened in dotnet/runtime#32036 (`Sse2.AddSaturate` was used for the first time). So this PR implements it for mono (with all Sse2 overloads) using named LLVM intrinsics. It turns out it's different between LLVM6 (we currently based on) and LLVM9 (we plan to migrate to soon). for `Vector128<byte>` overload it emits ```llvm %result = call <8 x i16> @llvm.x86.sse2.paddus.b(<16 x i8> %left, <16 x i8> %right) ``` which is then emitted as `vpaddusw`
monojenkins
force-pushed
the
sync-pr-32116-from-runtime
branch
from
4179ed4
to
eb9d9cc
Compare
|
@monojenkins build failed |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#32116, please do not edit or review it in this repo !!
!! Merge the PR only after the original PR is merged !!
Mono currently supports a limited subset of Sse1-Sse42 intrinsics used only by CoreLib internally. So once a new API is used to optimize things internally we also have to implement it in Mono. So it recently happened in dotnet/runtime#32036 (
Sse2.AddSaturatewas used for the first time).So this PR implements it for mono using named LLVM intrinsics. It turns out it's different for LLVM6 we currently based on and LLVM9 (we plan to migrate to soon).
it emits
which is then emitted as
vpaddusw