[debugger] Removing some asserts #19758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r message when it's possible.
…r message when it's possible.
…r message when it's possible.
vargaz
reviewed
May 11, 2020
…operty Task to continue async debug.
|
@vargaz , I tested on VsMac and with this change if we cannot find get_ObjectIdForDebugger and we cannot find the property Task, we cannot single step the async method, but we can continue debugging and breaking in other breakpoints, does it make sense for you? |
vargaz
approved these changes
May 13, 2020
UnityAlex
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
May 14, 2020
* Removing some asserts and returning err_invalid_argument with an error message when it's possible. * if we don't find method get_ObjectIdForDebugger we try to find the property Task to continue async debug. Cherry-picked by Alex Thibodeau with some moderate changes
spatil-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jun 15, 2020
* Removing some asserts and returning err_invalid_argument with an error message when it's possible. * if we don't find method get_ObjectIdForDebugger we try to find the property Task to continue async debug. Cherry-picked by Alex Thibodeau with some moderate changes
spatil-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jun 22, 2020
* Removing some asserts and returning err_invalid_argument with an error message when it's possible. * if we don't find method get_ObjectIdForDebugger we try to find the property Task to continue async debug. Cherry-picked by Alex Thibodeau with some moderate changes
spatil-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jun 29, 2020
* Removing some asserts and returning err_invalid_argument with an error message when it's possible. * if we don't find method get_ObjectIdForDebugger we try to find the property Task to continue async debug. Cherry-picked by Alex Thibodeau with some moderate changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some asserts and returning err_invalid_argument with an error message when it's possible.
Fixes #19651