Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes for System.Configuration/Settingsprovider #2

Closed
wants to merge 5 commits into from
Closed

Bugfixes for System.Configuration/Settingsprovider #2

wants to merge 5 commits into from

Commits on Dec 4, 2010

  1. [System.Configuration] Added check for SettingProviderAttribute on se… 

    …ttings class

There is no checkfor the SettingProviderAttribute attached to a Settings class.
.NET uses this to replace the default LocalSettingsProvider with your
own SettingsProvider.

The patch adds this feature.

Signed-off-by: Carsten Schlote <schlote@vahanus.net>
    @cschlote
    cschlote committed Dec 4, 2010
    Configuration menu
    Copy the full SHA
    455fb2f View commit details
    Browse the repository at this point in the history

  2. [System.Configuration] Fixed GetEvidenceHash() function to produce va… 

    …lid filenames

The previous implementation creates eventually invalid filenames in a
random fashion on linux, mac, windows by having '/' or '\' chars
in the base64 output. As a result you can't save or retrieve your settings
due to filesystem errors.

This patch changes the output to plain hex values. This is a bit longer
then a base64 string, but also 100% filesystem safe.

Might

Signed-off-by: Carsten Schlote <schlote@vahanus.net>
    @cschlote
    cschlote committed Dec 4, 2010
    Configuration menu
    Copy the full SHA
    8b838ef View commit details
    Browse the repository at this point in the history

  3. [System.Configuration] Fixed GetProductName() function 

    Added missing check for empty strongname. This case is now handled the
same way as a missing strongname.

GetProductName() now correctly uses _Url_ and assembly.EscapedCodeBase
for its output.

Signed-off-by: Carsten Schlote <schlote@vahanus.net>
    @cschlote
    cschlote committed Dec 4, 2010
    Configuration menu
    Copy the full SHA
    36e21cc View commit details
    Browse the repository at this point in the history

  4. [System.Data] Fixes for broken RO check 

    - When calling GetChanges() the ReadOnly check for DataCalumns must be
  turned off, as otherwise data of readonly columns can't be cloned
  into new rows for the new created DataSet/dataTable

Signed-off-by: Carsten Schlote <schlote@vahanus.net>
    @cschlote
    Carsten Schlote authored and cschlote committed Dec 4, 2010
    Configuration menu
    Copy the full SHA
    87f28a3 View commit details
    Browse the repository at this point in the history

  5. [System.Data] Extended CloneCopy() test with ReadOnly field 

    - It is recommended to set auto-increment fields to ReadOnly. When
  calling Copy() the check for ReadOnly must be omitted, otherwise
  you get an exception.
  The RadOnly attribute is set for the parent "Id" field to test
  proper handling of read-only fields.
- Source reindention and cleanups.

Signed-off-by: Carsten Schlote <schlote@vahanus.net>
    @cschlote
    Carsten Schlote authored and cschlote committed Dec 4, 2010
    Configuration menu
    Copy the full SHA
    cf131b8 View commit details
    Browse the repository at this point in the history