[2020-02] [Android] Enable access to up-to-date tzdata on Android 10+ #20350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://source.android.com/devices/architecture/modular-system/runtime#time-zone-data-interactions Context: https://source.android.com/devices/tech/config/timezone-rules#timezone-apex Maybe Fixes: xamarin/xamarin-android#5080 Add support to read ICANN timezone data from two new locations found on devices running Android 10+. The data in the previously searched location still exists but it's most likely out of date. On Android 10+ tzdata updates will be derived via an APEX TimeData package update, whose data directory this commit sets as the first location to be searched. This commit potentially fixes the Xamarin.Android issue mentioned above. "Potentially" because I can't be sure this is what's causing it since I'm unable to reproduce the issue locally. However, out-of-date tz database seems to be the most probable cause.
akoeplinger
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: please backport the fix to the 2020-02 branch, thanks!
Context: https://source.android.com/devices/architecture/modular-system/runtime#time-zone-data-interactions
Context: https://source.android.com/devices/tech/config/timezone-rules#timezone-apex
Context: https://android.googlesource.com/platform/frameworks/base/+/a1ae02519d6fb5de636fc8728dec7cb9b14de356
Maybe helps with: xamarin/xamarin-android#5080
Add support to read ICANN timezone data from two new locations found on
devices running Android 10+. The data in the previously searched
location still exists but it's most likely out of date.
On Android 10+ tzdata updates will be derived via an APEX TimeData
package update, whose data directory this commit sets as the first
location to be searched.
This commit potentially fixes the Xamarin.Android issue mentioned above.
"Potentially" because I can't be sure this is what's causing it since
I'm unable to reproduce the issue locally. However, out-of-date tz
database seems to be the most probable cause.
Backport of #20349.
/cc @akoeplinger @grendello