Build makefile to support Mac Catalyst #20537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praeclarum
requested review from
lambdageek,
marek-safar and
vargaz
as code owners
akoeplinger
reviewed
Nov 2, 2020
This was referenced Nov 4, 2020
|
@praeclarum can you tick the "Allow edits and access to secrets by maintainers" box so that I can add the changes Alexander requested? Or do you want to implement them? |
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
This is in response to the code review: mono#20537 (comment)
|
@rolfbjarne and @akoeplinger sorry for the delay, I have made the requested changes. Thanks for the review! |
rolfbjarne
approved these changes
Nov 10, 2020
|
@monojenkins backport to 2020-02 |
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Nov 10, 2020
This is in response to the code review: mono#20537 (comment)
akoeplinger
added a commit
that referenced
this pull request
Nov 11, 2020
Backport of #20537. Co-authored-by: Frank A. Krueger <fak@praeclarum.org> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces new Mac Catalyst support for mono!
Background Mac Catalyst allows a developer to use the traditionally iOS APIs - like UIKit - on macOS. It retains the same ABI as macOS x86_64, however, is compiled with a new
-targetflag that is required in all static and dynamic libraries.This patch is my first port of mono so I appreciate any code reviews. :-)
I started with a clean build target so as not to break current iOS and Mac support. There is the potential to merge this with the existing iOS support, but I think this method of a specific
maccat.mkfile is a cleaner separation.I discussed this publicly on the Merge Conflict podcast: https://www.mergeconflict.fm/225
I also show off the work on my Twitch stream: https://twitch.tv/FrankKrueger
This is the build script I've been using: