fix aarch64+clang compilation errors #21642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang doesn't need it, and clang also doesn't support the `optimize` attribute.
Otherwise, clang complains that "value-size does not match register size", since the 32-bit value (generally a literal 0) doesn't match the 64-bit x3 register.
|
@dotnet-policy-service agree company="Google" |
vargaz
reviewed
Apr 13, 2023
vargaz
approved these changes
Apr 13, 2023
|
What should I do about these failures? At least some of them seem like they might be flaky or unrelated, but I don't know how to rerun them. |
|
Note that ongoing mono development is happening in the dotnet/runtime repo. |
Should I resubmit this patch to that repo? |
|
Yes if possible. |
ThomasKuehne
pushed a commit
to ThomasKuehne/mono
that referenced
this pull request
Mar 23, 2024
* don't use the gcc workaround on clang clang doesn't need it, and clang also doesn't support the `optimize` attribute. * cast _zzq_default to a 64-bit type Otherwise, clang complains that "value-size does not match register size", since the 32-bit value (generally a literal 0) doesn't match the 64-bit x3 register.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of errors that show up when compiling Mono for aarch64 using clang on Linux.