[corlib] Fixes TimeZoneInfo.ParseTZBuffer abbrevs. #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=31432 Tests TimeZoneInfo.ParseTZBuffer with Europe/Moscow data that thrown at System.ThrowHelper.ThrowKeyNotFoundException () at System.Collections.Generic.Dictionary`2[System.Int32,System.String].get_Item (Int32 key)mscorlib/system/collections/generic/dictionary.cs:176 at System.TimeZoneInfo.ParseTimesTypes (System.Byte[] buffer, Int32 index, Int32 count, System.Collections.Generic.Dictionary`2 abbreviations) [0x0002f] in mcs/class/corlib/System/TimeZoneInfo.cs:1293 at System.TimeZoneInfo.ParseTZBuffer (System.String id, System.Byte[] buffer, Int32 length)
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=31432 In a few android devices TimeZoneInfo.ParseTZBuffer was failing ito parse Europe/Moscow with: at System.ThrowHelper.ThrowKeyNotFoundException () at System.Collections.Generic.Dictionary`2[System.Int32,System.String].get_Item (Int32 key)mscorlib/system/collections/generic/dictionary.cs:176 at System.TimeZoneInfo.ParseTimesTypes (System.Byte[] buffer, Int32 index, Int32 count, System.Collections.Generic.Dictionary`2 abbreviations) [0x0002f] in mcs/class/corlib/System/TimeZoneInfo.cs:1293 at System.TimeZoneInfo.ParseTZBuffer (System.String id, System.Byte[] buffer, Int32 length) It was failing while getting the third index [3] from] from abbrevs. abbrevs added values were the following: [0, MMT] [1, MT] [2, T] [4, MST] [5, ST] [6, T] [8, MDST] [9, DST] [10, ST] [11, T] [13, S] [15, M] [17, MSK] [18, SK] [19, K] [21, EET] [22, ET] [23, T] [25, MSD] [26, SD] [27, D] [29, EEST] [30, EST] [31, ST] [32, T] Index 3 was not added because its values is an empty string, as indexes with empty values are used in this case we are now adding them to the abbrevs dictionary. Fixes #31432
|
LGTM. |
kumpera
added a commit
that referenced
this pull request
Nov 13, 2015
[corlib] Fixes TimeZoneInfo.ParseTZBuffer abbrevs.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
[corlib] Fixes TimeZoneInfo.ParseTZBuffer abbrevs. Commit migrated from mono/mono@3bc22b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://bugzilla.xamarin.com/show_bug.cgi?id=31432
In a few android devices TimeZoneInfo.ParseTZBuffer was failing ito
parse Europe/Moscow with:
at System.ThrowHelper.ThrowKeyNotFoundException ()
at System.Collections.Generic.Dictionary
2[System.Int32,System.String].get_Item (Int32 key)mscorlib/system/collections/generic/dictionary.cs:176 at System.TimeZoneInfo.ParseTimesTypes (System.Byte[] buffer, Int32 index, Int32 count, System.Collections.Generic.Dictionary2 abbreviations) [0x0002f] in mcs/class/corlib/System/TimeZoneInfo.cs:1293at System.TimeZoneInfo.ParseTZBuffer (System.String id, System.Byte[] buffer, Int32 length)
It was failing while getting the third index [3] from] from abbrevs.
abbrevs added values were the following:
[0, MMT]
[1, MT]
[2, T]
[4, MST]
[5, ST]
[6, T]
[8, MDST]
[9, DST]
[10, ST]
[11, T]
[13, S]
[15, M]
[17, MSK]
[18, SK]
[19, K]
[21, EET]
[22, ET]
[23, T]
[25, MSD]
[26, SD]
[27, D]
[29, EEST]
[30, EST]
[31, ST]
[32, T]
Index 3 was not added because its values is an empty string, as indexes
with empty values are used in this case we are now adding them to the
abbrevs dictionary.
Fixes #31432