Fix Nemerle compilation (Do same as .Net) #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original discussion is here: https://bugzilla.novell.com/show_bug.cgi?id=689533 And this is the proposed patch: https://bugzillafiles.novell.org/attachment.cgi?id=426501
|
+1 to this pull request. In the bugzilla someone mentioned this patch causes regression in smcs, but:
So again, +1, plz accept this. |
|
+1 for Nemerle on Linux (with packages etc) too. |
vargaz
added a commit
that referenced
this pull request
Mar 11, 2012
Fix Nemerle compilation (Do same as .Net)
|
mono master no longer uses reflection.emit for c# compilation, so this can be merged now. If it breaks something, at least it won't be the C# compiler. |
|
Also, please merge this to mono-2-10 branch. |
|
The 2.10 branch uses the old reflection.emit based compilers, so it will probably break something there. |
|
How can i prove that patch doesn't break anything? I ask bcs i see no problems in my build with the patch. But of course i can miss something. |
|
Agree with Sectoid ? What are the tests we must run to make sure there are no problems ? |
|
merged it to 2.10. |
|
Great work. |
Merged
viniciusjarina
added a commit
that referenced
this pull request
May 31, 2012
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix Nemerle compilation (Do same as .Net) Commit migrated from mono/mono@8814ddb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original discussion is here:
https://bugzilla.novell.com/show_bug.cgi?id=689533
And this is the proposed patch:
https://bugzillafiles.novell.org/attachment.cgi?id=426501
Please accept this pull request it is essential to enable self compilation of Nemerle (https://github.com/rsdn/nemerle) in Linux.