Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] Import System.Diagnostics.Process #2610

Closed
wants to merge 0 commits into from

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Feb 12, 2016

No description provided.

@luhenry
Copy link
Contributor Author

luhenry commented Feb 15, 2016

build

@luhenry
Copy link
Contributor Author

luhenry commented Feb 15, 2016

@kumpera could you pease confirm that you do not see the _wapi_handle_... error message anymore?

@akoeplinger
Copy link
Member

This seems to break the Windows build:

"c:\j\workspace\w\msvc\mono.sln" (default target) (1) ->
"c:\j\workspace\w\msvc\libmono.vcxproj.metaproj" (default target) (6) ->
"c:\j\workspace\w\msvc\libmonoruntime.vcxproj" (default target) (7) ->
(ClCompile target) -> 
  ..\mono\metadata\icall.c(7854): error C2065: 'WapiFileTime' : undeclared identifier [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]
  ..\mono\metadata\icall.c(7854): error C2059: syntax error : ')' [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]
  ..\mono\metadata\icall.c(7858): error C2061: syntax error : identifier 'ves_icall_Microsoft_Win32_NativeMethods_GetCurrentProcessId' [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]
  ..\mono\metadata\icall.c(7858): error C2059: syntax error : ';' [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]
  ..\mono\metadata\icall.c(7858): error C2059: syntax error : 'type' [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]
  c:\j\workspace\w\mono\metadata/icall-def.h(44): error C2065: 'ves_icall_Microsoft_Win32_NativeMethods_GetCurrentProcessId' : undeclared identifier [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]
  ..\mono\metadata\icall.c(7989): error C2099: initializer is not a constant [c:\j\workspace\w\msvc\libmonoruntime.vcxproj]

    620 Warning(s)
    7 Error(s)

@luhenry luhenry force-pushed the referencesource-process branch 2 times, most recently from 64eae42 to 8888c9f Compare February 16, 2016 10:23
@luhenry
Copy link
Contributor Author

luhenry commented Feb 16, 2016

@akoeplinger the compilation is now fixed on windows

@akoeplinger
Copy link
Member

@ludovic-henry I ran the runtime tests and new process stress tests in a loop for an hour on my Ubuntu box and didn't see any crashes/failures :)

Looks like it needs a rebase though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants