More thread name improvements #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
|
I love this patch, what are the next steps for it? |
|
@alexrp, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
added 7 commits
May 12, 2016 14:01
We now do this in the thread main function.
…et_name (). This function has nothing to do with MonoThreadInfo structures, so the name is somewhat misleading. It only requires a native thread ID.
…s non-null. This is consistent with MS.NET behavior.
…' check + exception. MS.NET doesn't, so we shouldn't either. Bug: https://bugzilla.xamarin.com/show_bug.cgi?id=23206
…d name at thread startup. If we did consider this, an internal runtime thread that had its name set by a mono_thread_set_name_internal (..., FALSE /*managed*/, ...) call prior to starting would not have its native name set nor its name reported to the profiler.
…permanent'. The actual meaning is about whether or not the name is allowed to change after having been set by the mono_thread_set_name_internal () call; it has nothing to do with whether the call came from managed per se.
|
OK'd by @kumpera and was green prior to rebase, so merging. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
More thread name improvements Commit migrated from mono/mono@ce38129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.