Cleanup on gc bridge to support future optimizations #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * The output of the SCC analysis is passed to the client's `cross_references()` | ||
| * callback. This consists of 2 arrays, an array of SCCs (MonoGCBridgeSCC), | ||
| * and an array of "xrefs" (edges between SCCs, MonoGCBridgeXRef). The edges | ||
| * are encoded as "API indices", ie indexes in the SCC array. The client is |
There was a problem hiding this comment.
It's not the edges that are encoded as API indices, but the SCC.
There was a problem hiding this comment.
Would "edges are encoded as pairs of 'API indices'" be a better wording?
|
LGTM |
Consists mostly of - Comments - Consolidate duplicate dynarray implementations in new-bridge and tarjan-bridge into a single header full of statics
xmcclure
force-pushed
the
tarjan-opt-basic
branch
from
d156f95
to
31e1a2a
Compare
|
Rephrased the comment kumpera mentioned |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Cleanup on gc bridge to support future optimizations Commit migrated from mono/mono@0a8d5a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consists mostly of