Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing switch and functionality to al. #3463

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Add missing switch and functionality to al. #3463

merged 1 commit into from
Aug 29, 2016

Conversation

amanda-mitchell
Copy link

When running msbuild on mono against an architecture-specific
project that also defines satellite assemblies, the /platform
switch will be passed to al.exe. Mono's implementation of al.exe
does not support this switch, which results in a failed build.

This commit adds the /platform switch, which also required
changing the implementation from System.Reflection to
IKVM.Reflection because Mono's implementation of AssemblyBuilder
does not support the necessary options.

While testing this change, I also noticed a few attributes that
the MS version of al.exe will copy from "template" assemblies,
so I added support for those, as well.

@dnfclas
Copy link

dnfclas commented Aug 26, 2016

Hi @david-mitchell, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@monojenkins
Copy link
Contributor

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

@marek-safar
Copy link
Member

approve

@marek-safar
Copy link
Member

There is still at least one Type ambiguity

When running msbuild on mono against an architecture-specific
project that also defines satellite assemblies, the /platform
switch will be passed to al.exe. Mono's implementation of al.exe
does not support this switch, which results in a failed build.

This commit adds the /platform switch, which also required
changing the implementation from System.Reflection to
IKVM.Reflection because Mono's implementation of AssemblyBuilder
does not support the necessary options.

While testing this change, I also noticed a few attributes that
the MS version of al.exe will copy from "template" assemblies,
so I added support for those, as well.
@amanda-mitchell
Copy link
Author

@marek-safar Fixed.

@amanda-mitchell
Copy link
Author

The Windows x64 build failed because of a failed git operation, while Linux x64 FulAOT appears to be failing because of unrelated tests.

@marek-safar marek-safar merged commit 3c04587 into mono:master Aug 29, 2016
@amanda-mitchell
Copy link
Author

@marek-safar thanks for merging it!

Do you have any notion of how long it might take for this to find its way into an official release?

@marek-safar
Copy link
Member

I'll show up in the next release after mono 4.6 (probably 4.8)

@DavidACL
Copy link

@david-mitchell does this PR address this bug https://bugzilla.xamarin.com/show_bug.cgi?id=12671, and possibly the main issue outlined in this example repo: https://github.com/DavidACL/SatelliteAssemblyCustomAttributesIssue/tree/master

Seems like it would. Thanks.

@amanda-mitchell
Copy link
Author

@DavidACL, the PR does not affect any xbuild behavior; it only adds functionality to al that was necessary as I attempted to use msbuild on Mono/Mac to build a project that was originally created in Windows.

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Add missing switch and functionality to al.

Commit migrated from mono/mono@3c04587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants