Fix crash in SafePipeHandle.ReleaseHandle() on Windows #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReleaseHandle() methods tries to deallocate the handle as if it was a pointer to heap memory. But on Windows it's a HANDLE. The call to Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other platforms probably due to the emulated handles which are indeed heap allocated memory objects. But the underlying file descriptor is never closed so there should be a file descriptor leak on other platforms. This patch fixes the issue by calling MonoIO.Close() on the handle rather than Marshal.FreeHGlobal()
|
This is fine. |
madewokherd
pushed a commit
to madewokherd/mono
that referenced
this pull request
Nov 23, 2016
The ReleaseHandle() methods tries to deallocate the handle as if it was a pointer to heap memory. But on Windows it's a HANDLE. The call to Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other platforms probably due to the emulated handles which are indeed heap allocated memory objects. But the underlying file descriptor is never closed so there should be a file descriptor leak on other platforms. This patch fixes the issue by calling MonoIO.Close() on the handle rather than Marshal.FreeHGlobal() (cherry picked from commit 634ab61)
mderoy
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jan 24, 2018
The ReleaseHandle() methods tries to deallocate the handle as if it was a pointer to heap memory. But on Windows it's a HANDLE. The call to Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other platforms probably due to the emulated handles which are indeed heap allocated memory objects. But the underlying file descriptor is never closed so there should be a file descriptor leak on other platforms. This patch fixes the issue by calling MonoIO.Close() on the handle rather than Marshal.FreeHGlobal()
mderoy
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jan 24, 2018
The ReleaseHandle() methods tries to deallocate the handle as if it was a pointer to heap memory. But on Windows it's a HANDLE. The call to Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other platforms probably due to the emulated handles which are indeed heap allocated memory objects. But the underlying file descriptor is never closed so there should be a file descriptor leak on other platforms. This patch fixes the issue by calling MonoIO.Close() on the handle rather than Marshal.FreeHGlobal()
mderoy
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jan 24, 2018
The ReleaseHandle() methods tries to deallocate the handle as if it was a pointer to heap memory. But on Windows it's a HANDLE. The call to Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other platforms probably due to the emulated handles which are indeed heap allocated memory objects. But the underlying file descriptor is never closed so there should be a file descriptor leak on other platforms. This patch fixes the issue by calling MonoIO.Close() on the handle rather than Marshal.FreeHGlobal()
mderoy
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Jan 24, 2018
The ReleaseHandle() methods tries to deallocate the handle as if it was a pointer to heap memory. But on Windows it's a HANDLE. The call to Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other platforms probably due to the emulated handles which are indeed heap allocated memory objects. But the underlying file descriptor is never closed so there should be a file descriptor leak on other platforms. This patch fixes the issue by calling MonoIO.Close() on the handle rather than Marshal.FreeHGlobal()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReleaseHandle() methods tries to deallocate the handle as if it was a
pointer to heap memory. But on Windows it's a HANDLE. The call to
Marshal.FreeHGlobal() causes a crash on Windows. It doesn't crash on other
platforms probably due to the emulated handles which are indeed heap allocated
memory objects. But the underlying file descriptor is never closed so there
should be a file descriptor leak on other platforms.
This patch fixes the issue by calling MonoIO.Close() on the handle rather than
Marshal.FreeHGlobal()