Fix NRE in Win32 IpcChannel.StopListening() when no server started #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the System.Runtime.Remoting test suite fail in various places on Windows due to the TestFixtureTearDown method in BaseCalls throwing an NRE.
ntherning
deleted the
fix-NRE-in-Win32-IpcChannel.StopListening-when-no-server-started
branch
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…Channel.StopListening-when-no-server-started Fix NRE in Win32 IpcChannel.StopListening() when no server started Commit migrated from mono/mono@9f9d6ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the System.Runtime.Remoting test suite fail in various places on Windows due to the TestFixtureTearDown method in BaseCalls throwing an NRE.
The Unix IpcChannel.cs does the same null checks in StartListening()/StopListening() as those I added in the Win32 version in this PR.