Bugfix Ping.cs

[jogibear9988]

Should fix : https://bugzilla.xamarin.com/show_bug.cgi?id=42249

[monojenkins]

Hello! I'm the build bot for the Mono project.

I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.

Contributors can ignore this message.

[dnfclas]

Hi @jogibear9988, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[akoeplinger]

I don't know why we need a non-loopback address, but this is not the correct way of fixing it.
You need to modify SendPrivileged() so it doesn't rely on GetNonLoopbackIP().

[jogibear9988]

I've changed the COde

[jogibear9988]

I also don't know why, and why is the first one found the correct ine? But ping also works when I add 127.0.0.1 to hosts, so I thought this is ok.

[jogibear9988]

When I look again on this, I think the whole Code is wrong! We need the IP wich was used for send, and not the first one with correct hostname.
But how can we find out?

[jogibear9988]

seems like netcore does not need this https://github.com/dotnet/corefx/blob/master/src/System.Net.Ping/src/System/Net/NetworkInformation/Ping.Unix.cs

[akoeplinger]

Yeah, the corefx code looks better in that regard. You can try porting the relevant pieces.

[jogibear9988]

I will try to use the corefx code. Is it not planed to migrate a this Assembly in Mono?

Which Editor can I use? I tried with VS2015, but it crashes with the Mono Solution.

[jogibear9988]

With the new change it does work. And it's the same as in corefx. They also only use the destination IP

[jogibear9988]

@akoeplinger is the patch so ok?

[jogibear9988]

@akoeplinger - do i still need to do changes on my patch?