Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[corlib] Makes GetReferencedAssemblies test more reliable #5720

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

marek-safar
Copy link
Member

No description provided.

Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it'd be nice to understand which referenced assembly caused the issue.

@marek-safar
Copy link
Member Author

Don't think it matters, we want to test specific case not randomly redirected assemblies

@marek-safar marek-safar merged commit 72c86fe into mono:master Oct 6, 2017
@akoeplinger
Copy link
Member

please backport to 2017-10 too

@akoeplinger
Copy link
Member

For future reference the assembly that caused this test to fail in XA was Xamarin.Android.NUnitLite.dll which has Flags == AssemblyNameFlags.PublicKey:

alexander:~/dev/xamarin-android$ ikdasm --assemblyref /Users/alexander/dev/xamarin-android/bin/TestDebug/monodroid_corlib_test.dll
AssemblyRef Table
1: Version=2.0.5.0
	Name=mscorlib
	Flags=0x00000000
	Public Key:
0x00000000: 7C EC 85 D7 BE A7 79 8E

2: Version=1.0.0.0
	Name=Xamarin.Android.NUnitLite
	Flags=0x00000001
	Public Key:
0x00000000: 00 24 00 00 04 80 00 00 94 00 00 00 06 02 00 00
0x00000010: 00 24 00 00 52 53 41 31 00 04 00 00 11 00 00 00
0x00000020: 43 8A C2 A5 AC FB F1 6C BD 2B 2B 47 A6 27 62 F2
0x00000030: 73 DF 9C B2 79 5C EC CD F7 7D 10 BF 50 8E 69 E7
0x00000040: A3 62 EA 7A 45 45 5B BF 3A C9 55 E1 F2 E2 81 4F
0x00000050: 14 4E 5D 81 7E FC 4C 65 02 CC 01 2D F3 10 78 33
0x00000060: 48 30 4E 3A E3 85 73 C6 D6 58 C2 34 02 58 21 FD
0x00000070: A8 7A 0B E8 A0 D5 04 DF 56 4E 2C 93 B2 B8 78 92
0x00000080: 5F 42 50 3E 9D 54 DF EF 9F 95 86 D9 E6 F3 8A 30
0x00000090: 57 69 58 7B 1D E0 1F 6C 04 10 32 8B 2C 97 33 DB

...

akoeplinger added a commit to akoeplinger/xamarin-android that referenced this pull request Nov 4, 2017
jonpryor pushed a commit to dotnet/android that referenced this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants