[corlib] Enable machine.config dependant version of CryptoConfig for net_4_x profile only #7871
Conversation
marek-safar
force-pushed
the
corlib-fixes
branch
from
5943c61
to
2258cf7
Compare
| #if FULL_AOT_DESKTOP // TODO: why is this special cased? we could use AesManaged like other full AOT profiles | ||
| name = "System.Security.Cryptography.AesCryptoServiceProvider, System.Core"; | ||
| #else | ||
| #if MONOTOUCH || XAMMAC |
There was a problem hiding this comment.
this would need to add XAMMAC_4_5 to keep the previous meaning. But I think we should just go with AesManaged on all !FEATURE_CRYPTO_CONFIGURABLE platforms.
There was a problem hiding this comment.
The file was not used before with XAMMAC_4_5 and it returned null for the value (that's another bug).
.NET returns AesCryptoServiceProvider and I don't think we need to break the compatibility here. My preference would be to remove if MONOTOUCH || XAMMAC instead but that needs more work
There was a problem hiding this comment.
Oh right, I got confused by all the conditions here :)
marek-safar
force-pushed
the
corlib-fixes
branch
from
2258cf7
to
90b52fa
Compare
|
@monojenkins backport 2018-02 |
|
@monojenkins commit apidiff |
marek-safar
force-pushed
the
corlib-fixes
branch
from
4b47800
to
58d4de6
Compare
|
@monojenkins build Linux i386 Coop GC |
|
@monojenkins build Windows i386 |
marek-safar
force-pushed
the
corlib-fixes
branch
from
58d4de6
to
a1ab08b
Compare
|
@monojenkins backport 2018-04 |
Fixes #7716