HttpListener now listens on default ports if not specified instead of random #891
Conversation
This is more like suggestion then actual pull request since I'm not 100% that baseUri.AbsolutePath is covering all scenarios... One other option could be baseUri.OriginalString(breaking change?) For more info about Mono bug see mono/mono#891 and http://stackoverflow.com/questions/19741880/nancy-mono-self-host-wont-start-on-port-80. Basically problem is that with ToString() ports 80 and 443 are removed and Mono's HttpListener has bug that does not listen on default port if port is not specified but random. This workaround is to be able to work on older versions of Mono because apt-get mono is updating really slow and will take probably year to get into apt-get... As you wish ;)
|
Could you write unit test for the change |
|
Should I write unit tests for mcs/class/System/System.Net/ListenerPrefix.cs and send different strings in and see if Properties(Secure, Host, Port, Path) are correct or mcs/class/System/System.Net/HttpListener.cs were port will actually be opened? Notice that if actually opening HttpListener.cs will require "sudo" because opening listener on port 80 requires sudo access. |
|
That's unit test. No need to check whether the port is actually open/working. It'd be enough to use the combination Nancy has and assert on ToString result |
|
Unfortunately mcs/class/System/System.Net/ListenerPrefix.cs is private class so only way to test it directly would be using reflection(I can do that if you want :))... |
HttpListener now listens on default ports if not specified instead of random
|
I guess this is included within mono 3.8 right? |
|
Yes. |
…-typeof Use typeof instead of Type.GetType for webconnection HttpsClientStream
In method public static void CheckUri I just made code a bit nicer.
In method Parse I fixed bug where default_port variable was set but never used in case if URI did not have port specified. Since port was set by default 0 HttpListener would listen on random port instead 80 or 443. Also notice that this class is private and only used by Mono so CheckUri is always called before Parse() which means only "http://" and "https://" schemas are possible so I changed beginning of Parse method a bit. "optimization" :)
This is also behaviour of .Net(no port specified results in port 80 on http schema).
I ran into this problem using Nancy because there self hosting accepts Uri objects which is later sent to HttpListener prefixes by using .ToString() which omits port number(see Uri.cs).
Seems like some other guys ran into same problem here: http://stackoverflow.com/questions/19741880/nancy-mono-self-host-wont-start-on-port-80