[corlib] Use String from CoreCLR #9134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhenry
reviewed
Jun 14, 2018
| Assert.IsNotNull (ex.Message, "#A4"); | ||
| Assert.AreEqual ("value", ex.ParamName, "#A5"); | ||
| } | ||
| Assert.AreEqual (string.Empty, new String ((sbyte*) null, 0, 0)); |
There was a problem hiding this comment.
This means we are not expecting an ArgumentNullException anymore, correct?
luhenry
reviewed
Jun 14, 2018
| @@ -593,7 +593,8 @@ internal enum ExceptionArgument { | |||
| byteOffset, | |||
| minimumBufferSize, | |||
| offset, | |||
| values | |||
| values, | |||
| comparisonType | |||
There was a problem hiding this comment.
You could have comparisonType, to avoid the 2-line changes next time you need to add a value to this enum.
marek-safar
force-pushed
the
corefx-string
branch
2 times, most recently
from
0ce3963
to
4befde8
Compare
marek-safar
force-pushed
the
corefx-string
branch
from
4befde8
to
74e23f6
Compare
marek-safar
force-pushed
the
corefx-string
branch
from
74e23f6
to
61ca696
Compare
akoeplinger
approved these changes
Jul 15, 2018
|
@monojenkins commit apidiff and csproj |
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(depends on fast-span)