[MWF] Implement multi-display support on Linux (Fixes #325669) #943
Conversation
| } else { | ||
| displaySize = Screen.PrimaryScreen.WorkingArea.Size; | ||
| } | ||
| this.Location = new Point(displaySize.Width / 2 - w / 2, displaySize.Height / 2 - h / 2); |
There was a problem hiding this comment.
This should account for the work area's top-left corner, not assume it's (0,0).
|
@madewokherd: thanks for your review comments. I updated the patch. |
| } | ||
| } | ||
|
|
||
| public static Rectangle WorkingArea { | ||
| get { | ||
| return XplatUI.WorkingArea; | ||
| // TODO: this doesn't account for taskbar, launcher etc. | ||
| return Screen.PrimaryScreen.Bounds; |
There was a problem hiding this comment.
What's the problem with XplatUI.WorkingArea, or Screen.PrimaryScreen.WorkingArea? Then we could implement it in backends later without touching this.
There was a problem hiding this comment.
XplatUI.WorkingArea returns the working area of all screens (at least for X11). But Screen.PrimaryScreen.WorkingArea would be better than ...Bounds. I'll change that.
|
Hmm, I didn't know we had the ability to (badly) query workarea on X11. It'd be nice to not break the part of it that works, although properly solving it is more work. Maybe for now you could have XplatUIX11.AllScreens intersect the screen bounds with _NET_WORKAREA to calculate each screen's work area? That's the best we can do without _UNITY_NET_WORKAREA_REGION anyway. |
|
I don't see why fixing XplatUIX11.WorkingArea should be part of this change. I think using Screen.PrimaryScreen.WorkingArea in SystemInformation.WorkingArea gives us what MSDN documentation states ("WorkingArea always returns the work area of the primary monitor."). IMO additional improvements should be part of separate patch sets. (Just as some background information: we have a custom mono version with additional bugfixes; most of them got attached to issues in bugzilla but many never got applied. I'm currently going through all of our patches in preparation for updating to Mono 3.x. Unfortunately I don't have time to make extra nice-to-have changes since I need to get back to my main project) |
|
The fix for bug #15462 (commit de64851) isn't really part of implementing multi-display support, but it only works correctly if these changes got merged, that's why I added it to this pull request. |
|
Need maintainer approval to build this pull request. |
| [MonoTODO] | ||
| internal override Screen[] AllScreens { | ||
| get { | ||
| // To support multiples, we need to use GetMonitorInfo API on Win32 |
There was a problem hiding this comment.
If we are going to be calling this method, we should not be throwing an exception.
So let us return null, to indicate "Do not have support for this", and deal with that in the upper layers.
There was a problem hiding this comment.
Done, in both XplatUIWin32.cs and XplatUICarbon.cs
The number of displays and sizes can be retrieved with the help of libXinerama. The implementation was done in a way that is backwards compatible, so on non-Linux systems or when libXinerama is not available the behavior will be the same as before. Also fixed the implementation of FormStartPosition.CenterScreen to bring up the form centered on the current display (with the current display being either the screen the top left corner of the owner form is on, or if there is no owner the screen that has the mouse pointer). This fixes Novell bug #325669 on Linux (https://bugzilla.novell.com/show_bug.cgi?id=325669).
The Screen.FromRectangle method was too simple minded. It did not try to find the best match for a screen when the system has more than one screen. The new implementation makes at least some effort to find the closest screen with the most overlap with the rectangle.
The fix mimics the behavior of Windows/.NET.
[MWF] Implement multi-display support on Linux (Fixes #325669)
…-crash-on-invalid-method-header Return NULL so client can raise exception rather than asserting on invalid method header (case 1032601)
The number of displays and sizes can be retrieved with the help of
libXinerama. The implementation was done in a way that is backwards
compatible, so on non-Linux systems or when libXinerama is not
available the behavior will be the same as before.
Also fixed the implementation of FormStartPosition.CenterScreen to
bring up the form centered on the current display. This fixes
Novell bug#325669 on Linux
(https://bugzilla.novell.com/show_bug.cgi?id=325669).