[metadata] Fix use after free of signatures of some dynamic methods #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When freeing dynamic methods in mono_free_method, we remove entries in the method image's hashtables, hashed by the soon to be freed method signature.
BrzVlad
changed the title
|
looks good. why is it needed? |
lewurm
approved these changes
Aug 3, 2018
|
@lewurm this crash happens on the interp System.core xunit, when rehashing some tables. It could also happen in theory with default mono though. |
alexanderkyte
pushed a commit
to alexanderkyte/mono
that referenced
this pull request
Aug 16, 2018
…ono#9863) * [metadata] Cache method signature in correct image hash When freeing dynamic methods in mono_free_method, we remove entries in the method image's hashtables, hashed by the soon to be freed method signature. * [metadata] Avoid unnecessary alloc
ramanbs-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Oct 28, 2020
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ono/mono#9863) * [metadata] Cache method signature in correct image hash When freeing dynamic methods in mono_free_method, we remove entries in the method image's hashtables, hashed by the soon to be freed method signature. * [metadata] Avoid unnecessary alloc Commit migrated from mono/mono@60643fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.