Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Make -Wreturn-type into an error. #9915

Merged
merged 1 commit into from Jan 21, 2019
Merged

[runtime] Make -Wreturn-type into an error. #9915

merged 1 commit into from Jan 21, 2019

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Aug 6, 2018

No description provided.

@lambdageek
Copy link
Member

All the autoconf tests are failing... not sure if that's because it should be -Werror=return-type or because all the autoconf tests trigger the warning.

@vargaz vargaz force-pushed the missing-return branch 2 times, most recently from 84c2460 to 51b9ae1 Compare August 6, 2018 18:59
jaykrell
jaykrell approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@jaykrell jaykrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to lookup what this is. Warn/error for missing return type, then C89 defaults to int.

@vargaz vargaz force-pushed the missing-return branch 3 times, most recently from fb1706d to 3871926 Compare August 8, 2018 13:14
@vargaz vargaz requested a review from kumpera as a code owner August 8, 2018 14:58
@vargaz vargaz requested a review from BrzVlad as a code owner August 9, 2018 03:38
@vargaz vargaz merged commit 86bae56 into mono:master Jan 21, 2019
@vargaz vargaz deleted the missing-return branch January 21, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewurm lewurm lewurm approved these changes

@jaykrell jaykrell jaykrell approved these changes

@luhenry luhenry Awaiting requested review from luhenry

@marek-safar marek-safar Awaiting requested review from marek-safar

@kumpera kumpera Awaiting requested review from kumpera

@BrzVlad BrzVlad Awaiting requested review from BrzVlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vargaz @lambdageek @lewurm @jaykrell