Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[counters] Add sample and accessors to mono counters API #992

Merged
merged 5 commits into from May 6, 2014

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Apr 15, 2014

No description provided.

@monoadmin
Copy link

The build failed.
Refer to this link for build results: http://monojenkins.cloudapp.net/job/Mono-Incoming/8/

@monoadmin
Copy link

The build failed.
Refer to this link for build results: http://monojenkins.cloudapp.net/job/Mono-Incoming/10/

@monoadmin
Copy link

The build failed.
Refer to this link for build results: http://monojenkins.cloudapp.net/job/Mono-Incoming/12/

@luhenry luhenry changed the title [counters] Improve mono counters API and integrate it to the log profiler [counters] Improve mono counters API Apr 30, 2014
@luhenry luhenry changed the title [counters] Improve mono counters API [counters] Add sample and accessors to mono counters API Apr 30, 2014
@monoadmin
Copy link

The build failed.
Refer to this link for build results: http://monojenkins.cloudapp.net/job/Mono-Incoming/15/

…ctly instead of mono_counter_get_size

The use of sizeof will enable compilers optimization on memcpy.
Used MONO_COUNTER_WORD for gint32 variable, crashed on 64bits platform.
This was previously used to not store counters that were not going to be dumped, but because we can now sample them, we have to make sure that they are stored, even if we do not plan to dump or sample them.
kumpera added a commit that referenced this pull request May 6, 2014
[counters] Add sample and accessors to mono counters API
@kumpera kumpera merged commit 46cccd7 into mono:master May 6, 2014
@luhenry luhenry deleted the ludovic-counters-pr1 branch May 6, 2014 23:49
AlexKnauth pushed a commit to AlexKnauth/mono that referenced this pull request Nov 2, 2023
…driveinfo-isready

Fix monoTODO where driveinfo.IsReady is unimplemented FB1028143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants