Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Add using writes the wrong reference down for a framework assembly #6061

Closed
Therzok opened this issue Sep 21, 2018 · 4 comments
Closed

Add using writes the wrong reference down for a framework assembly #6061

Therzok opened this issue Sep 21, 2018 · 4 comments
Labels
Area: C# Binding vs-sync
Milestone
7.7

Comments

@Therzok
Copy link
Contributor

Therzok commented Sep 21, 2018 •
edited by xamarin-release-manager

When adding a GAC dll reference, since we use reference assemblies for a given .net api, we need to tell Roslyn which assembly to resolve to.

The code fix would add:
\Library\Frameworks\Mono.framework\Versions\$version\mono\lib\4.7-api\MyDll.dll

What we need to do is import this service:
http://source.roslyn.io/#Microsoft.VisualStudio.LanguageServices/Implementation/ProjectSystem/MetadataReferences/VisualStudioFrameworkAssemblyPathResolverFactory.cs,18

VS bug #691667
mkrueger added a commit that referenced this issue Oct 8, 2018
@mkrueger
Fixes issue #6061 Add using writes the wrong reference down for a
c7dc952 
framework assembly
@xamarin-release-manager xamarin-release-manager added this to the 7.8 milestone Oct 11, 2018
Therzok pushed a commit that referenced this issue Oct 16, 2018
@mkrueger @Therzok
Fixes issue #6061 Add using writes the wrong reference down for a
b313b5d 
framework assembly
Therzok added a commit that referenced this issue Oct 16, 2018
@Therzok
Merge pull request #6228 from mono/master-issue6061
7137ac5 
Fixes issue #6061 Add using writes the wrong reference down for a
@xamarin-release-manager
Copy link
Contributor

Fixed in version 7.8.0.889 (master)

Pull Request #6228 merged by: Marius Ungureanu
Author: mono
Commit: 7137ac5 (mono/monodevelop)

monojenkins pushed a commit that referenced this issue Oct 16, 2018
@mkrueger @monojenkins
Fixes issue #6061 Add using writes the wrong reference down for a fra…
6f2884c 
…mework assembly
slluis added a commit that referenced this issue Oct 17, 2018
@slluis
Merge pull request #6359 from mono/backport-pr-6228-to-release-7.7
da19e1f 
[release-7.7] Fixes issue #6061 Add using writes the wrong reference down for a
@xamarin-release-manager
Copy link
Contributor

Fixed in version 7.7.0.1663 (release-7.7)

Pull Request #6359 merged by: Lluis Sanchez
Author: mono
Commit: da19e1f (mono/monodevelop)

vancura pushed a commit that referenced this issue Oct 23, 2018
@mkrueger
Fixes issue #6061 Add using writes the wrong reference down for a
7cd8c7e 
framework assembly
@xamarin-release-manager xamarin-release-manager modified the milestones: 7.8, 7.7 Oct 24, 2018
@xamarin-release-manager
Copy link
Contributor

Fixed in version 8.0.0.471 (release-8.0)

Pull Request #6228 merged by: Marius Ungureanu
Author: mono
Commit: 7137ac5 (mono/monodevelop)

@xamarin-release-manager
Copy link
Contributor

Fixed in version 8.6.0.802 (master)

Pull Request #6228 merged by: Marius Ungureanu
Author: mono
Commit: 7137ac5 (xamarin/monodevelop)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: C# Binding vs-sync
Projects
None yet
Milestone
7.7
Development

No branches or pull requests
4 participants
@Therzok @slluis @mkrueger @xamarin-release-manager