This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Diff viewer #276
Closed
Diff viewer #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A close button is no required here. This is a view, not a dialog. |
|
Yeah, but there's no way to exit the diff view. It replaces the editor view. What if the user wants to go back to the editor view after viewing the diff? Also, the text modification still remains. :P |
|
I found it a necessity, therefore the patch to fix this. I still don't find it logical that the user has to reopen the document to exit the diff view. |
|
I failed to mention. The close view button switches you to the editor view, doesn't close the view. |
|
New pull found at #277 |
nosami
pushed a commit
that referenced
this pull request
May 23, 2016
…highlight-error Fix index out of bounds semantic highlight error
DavidKarlas
pushed a commit
that referenced
this pull request
Mar 11, 2019
Fixes VSTS Bug 803041: TextEditor causes System.ArgumentException:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a close view button which sends you to the editor view.
Text was awkwardly changing from Unified Diff to Patch after the first click. Fixed this issue.