This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Fixed 'Bug 58102 - FocusCurrentDocument command doesn't work if you #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are currently on a pad that has auto-hide' This command used to be just to pulse the caret posititon without focussing. However it's now called focus document - so the purpose changed.
Therzok
approved these changes
Jul 18, 2017
slluis
suggested changes
Jul 18, 2017
|
Actually, Document.Select() should already be grabbing the focus after merging #2746. Can you please verify? |
|
The bug with auto-hide pads is not fixed after merging #2746 (although that does fix focus from docked pads) This fix works for me with auto-hide pads. |
|
@mkrueger ping |
|
@pong - The fix works for me. I'm not sure how 'select' is defined - selection doesn't 100% mean grab focus - it could be just a bring to front. It's the question how to define Document.Select() behavior. I didn't want to produce side effects with a behavior change of Select (). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are currently on a pad that has auto-hide'
This command used to be just to pulse the caret posititon without
focussing. However it's now called focus document - so the purpose
changed.