This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Multi-File+Folder selection commit #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of MultiSelection changing type of the CommitCommand Handler. Next will be modifying the Commit Command.
This allows you to select multiple navigation nodes and commit them. This is an extension of PR #286, and enhances support for it. But here comes a question: Should I remove the CommandUpdateHandler? This command can get too CPU intensive in some cases, because of recursive directory searches. We have the MessageBox on operations that cannot be done. I'll add another commit if we need this.
|
Also, I have another question for VCS Command Update Handlers. Shouldn't the selected items be cached at least for tests? We're calling the GetItems () maaany times for just one menu update. There's no real possibility of items changing between tests. |
Changed algorithm of Commit to handle multi-repository commits. Moved FindMostSpecificParent from CreatePatchCommand to VersionControlItemList in case we need it somewhere else too.
|
@slluis Fixed them all, should now support multi-repository commits. (Will open up more dialogs.) |
slluis
added a commit
that referenced
this pull request
May 20, 2013
Multi-File+Folder selection commit
DavidKarlas
added a commit
that referenced
this pull request
Mar 11, 2019
Fix 806871: Breakpoint glyph doesn't change to filled circle when bre…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #286. It allows you to select multiple navigation nodes and commit them in a batch.
Also, refactoring on FindMostSpecificParent. Moved from CreatePatchCommand to VersionControlItemList.