Implement "add new" and "rename" for solution folder files #4794
Conversation
The new file dialog already saves the project, the command handler doesn't need to
When renaming system files, select the filename without the extension, as for project files
The starting value of the rename entry was the node name, but that might not match the node label, so allow handlers to customize it
The IFileItem.FileName API is actually a path, which makes it pretty confusing to read code that uses it. Fix this for SolutionFolderFileNode by implementing the property explicitly and instead exposing Path and Name properties, like SystemFile does.
|
Hello, Build Taken from :- https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1688171&tab=artifacts&_a=summary Observations :- Build Info :- have also marked following bugs as QA Approved :- Screenshot link :- http://recordit.co/XGQMbb1coU Hence marking this as “QA Approved ” |
| protected void OnAddNewFiles () | ||
|
|
||
| [CommandHandler (ProjectCommands.AddNewFiles)] | ||
| protected async void OnAddNewFiles () |
There was a problem hiding this comment.
Why does this need to be async?
| /* [CommandHandler (ProjectCommands.AddNewFiles)] | ||
| protected void OnAddNewFiles () | ||
| [CommandHandler (ProjectCommands.AddNewFiles)] | ||
| protected async void OnAddNewFiles () |
There was a problem hiding this comment.
Why does this need to be async?
There was a problem hiding this comment.
So if there's an exception in the called async method, we get a callstack with caller info
There was a problem hiding this comment.
There is no async method being called here?
There was a problem hiding this comment.
Ah, during development this method was awaiting on solution save, but I moved that to the new file dialog for consistency with what happens with projects
Fixes issue #4775 - Cannot add new file to solution items
Fixes issue #4774 - Cannot rename solution items