This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[Core] Fix null reference when opening SDK style project #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On opening a SDK style project sometimes a null reference exception was logged. System.NullReferenceException: Object reference not set to an instance of an object at MonoDevelop.Projects.MSBuild.DefaultMSBuildEngine+<FindGlobItemsIncludingFile>d__85.MoveNext () in MonoDevelop.Projects.MSBuild/DefaultMSBuildEngine.cs:1441 at System.Linq.Enumerable+WhereEnumerableIterator`1[TSource].MoveNext () in System/Linq/Where.cs:140 at MonoDevelop.Projects.Project.OnFileCreatedExternally (System.String fileName) in MonoDevelop.Projects/Project.cs:4293 at MonoDevelop.Projects.Project+<>c__DisplayClass338_0.<OnFileCreated>b__0 () in MonoDevelop.Projects/Project.cs:4258 This was difficult to reproduce. In the end adding a Thread.Sleep in MSBuildProjectInstance's Dispose and Evaluate methods between where the engine is set and the projectInstance is set was a way to make it happen more consistently. So the problem seems to be that if a file is generated externally when the engine is not null but the projectInstance is null then a null reference exception would occur. Now the projectInstance being null is handled. The file being generated on project load was a .tmp file that would not be added to the project. Fixes VSTS #611795 - NRE when file externally added
Add the same engine and projectInstance checks to the FindUpdateGlobItemsIncludingFile method so it is consistent with the FindGlobItemsIncludingFile method.
slluis
approved these changes
Jun 12, 2018
Therzok
approved these changes
Jun 12, 2018
|
@monojenkins backport release-7.6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On opening a SDK style project sometimes a null reference exception
was logged.
This was difficult to reproduce. In the end adding a Thread.Sleep in
MSBuildProjectInstance's Dispose and Evaluate methods between where
the engine is set and the projectInstance is set was a way to make it
happen more consistently. So the problem seems to be that if a file
is generated externally when the engine is not null but the
projectInstance is null then a null reference exception would occur.
Now the projectInstance being null is handled. The file being
generated on project load was a .tmp file that would not be added
to the project.
Fixes VSTS #611795 - NRE when file externally added