This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[Ide] Improve Pasting into Solution pad #6158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pasting data into the solution pad, it might happen that the currently selected node can not handle the data. This is for example the case if a file is selected, the user would expect the data to be pasted into the same folder. This patch adds some logic to try pasing into the parent node, if the currently selected node can not handle it. Fixes VSTS #666943
Therzok
approved these changes
Oct 2, 2018
|
@monojenkins backport release-7.7 |
slluis
suggested changes
Oct 3, 2018
|
@slluis isn't it a kind of an opt-in now? If the node doesn't want to handle the data, the parent has the ability to decide in https://github.com/mono/monodevelop/pull/6158/files#diff-50d02569d1ec7f037ba42611f2066af6R1290 by checking the node and the data in |
|
I mean that the new behavior should be opt-in. Existing node builders should not be affected by this behavior change unless they explicitly decide so. |
|
Rebased & added opt-in to master-vnext. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pasting data into the solution pad, it might happen that the currently selected node can not handle the data. This is for example the case if a file is selected, the user would expect the data to be pasted into the same folder.
This patch adds some logic to try pasing into the parent node, if the currently selected node can not handle it.
Fixes VSTS #666943
NOTE: this depends on #6169