Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

[7.7]Fix 668301: [Feedback] Unable to change font colors for vb.net by Vis… #6618

Merged
merged 2 commits into from Nov 16, 2018

Conversation

Therzok
Copy link
Contributor

@Therzok Therzok commented Nov 16, 2018

…ual Studio Community 2017 for Mac

Fixes VSTS #722812 - No syntax highlighting for .vb files

…ual Studio Community 2017 for Mac

Fixes VSTS #722812 - No syntax highlighting for .vb files
@Therzok Therzok changed the title Fix 668301: [Feedback] Unable to change font colors for vb.net by Vis… [7.7]Fix 668301: [Feedback] Unable to change font colors for vb.net by Vis… Nov 16, 2018
@Therzok Therzok added this to the 7.7 milestone Nov 16, 2018
@slluis
Copy link
Member

slluis commented Nov 16, 2018

@monojenkins backport master

@monojenkins
Copy link
Contributor

@slluis backporting to master failed, the patch results in conflicts:

Applying: Fix 668301: [Feedback] Unable to change font colors for vb.net by Visual Studio Community 2017 for Mac
Using index info to reconstruct a base tree...
M	main/msbuild/ReferencesRoslyn.props
M	main/src/addins/VBNetBinding/VBNetBinding.addin.xml
M	main/src/core/MonoDevelop.Ide/ExtensionModel/MonoDevelop.Ide.addin.xml
Falling back to patching base and 3-way merge...
Auto-merging main/msbuild/ReferencesRoslyn.props
CONFLICT (content): Merge conflict in main/msbuild/ReferencesRoslyn.props
error: Failed to merge in the changes.
Patch failed at 0001 Fix 668301: [Feedback] Unable to change font colors for vb.net by Visual Studio Community 2017 for Mac

Please backport manually!

@slluis
Copy link
Member

slluis commented Nov 16, 2018

Nevermind, tried to backport the wrong PR.

@slluis
Copy link
Member

slluis commented Nov 16, 2018

Syntax highlighting now works, but the editor shows an error underline for the whole text. This does not happen on 7.6.11.

@slluis slluis merged commit 0b774be into release-7.7 Nov 16, 2018
@slluis slluis deleted the release-7.7-vsts722812 branch November 16, 2018 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants