This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[Ide] Simpler culture specific resource file template fix … #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original fix to allow culture specific resource files (e.g.
Resources.de.resx) to be created by the New File dialog broke how
the ${Name} property was generated in new files. This could cause
invalid C# code to be generated for a new C# file. A simpler fix
is to not use "${Name}.resx" for the name of the file template but
specify a default file extension. This allows culture specific
.resx files to be created and also matches the behaviour of the
C# file template, which already supports creating new files with
a dotted name (e.g. Resources.Designer.cs)
Fixes VSTS #733182 - Invalid C# file created with new Library project
Fixes VSTS #579048 - Unable to create a culture specific resx files
through the 'New File ..' menu in the Solutions Explorer right click.
slluis
approved these changes
Nov 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix to allow culture specific resource files (e.g.
Resources.de.resx) to be created by the New File dialog broke how
the ${Name} property was generated in new files. This could cause
invalid C# code to be generated for a new C# file. A simpler fix
is to not use "${Name}.resx" for the name of the file template but
specify a default file extension. This allows culture specific
.resx files to be created and also matches the behaviour of the
C# file template, which already supports creating new files with
a dotted name (e.g. Resources.Designer.cs)
Fixes VSTS #733182 - Invalid C# file created with new Library project
Fixes VSTS #579048 - Unable to create a culture specific resx files
through the 'New File ..' menu in the Solutions Explorer right click.