Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

KeyPair.Generate failure tests #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KeyPair.Generate failure tests #55

wants to merge 3 commits into from

Conversation

dougrathbone
Copy link

Hi there,

I've written a test to prove the failure of KeyPair failing with a casting exception.

I'm going to go digging into it, but I'm not sure where the problem exists.

Thoughts?

…tion 'Unable to cast object of type 'Sharpen.RSAPrivateKey' to type 'Sharpen.RSAPrivateCrtKey'. Linked to #54
… 'Unable to cast object of type 'Sharpen.RSAPrivateKey' to type 'Sharpen.RSAPrivateCrtKey'. Linked to #54
@alanmcgovern
Copy link
Member

I don't want to put arbitrary binaries in the repository as it is a nightmare for us when trying to keep things up to date and building on every platform. Can you write your testcases without requiring a bunch of mono specific assemblies being included in the repository?

@dougrathbone
Copy link
Author

With all due respect, I think you should at least accept the pull request into your own repo to see me reproduce the issue. Ignoring me taking the time to raise it for you just because of minutia is a bit saddening. I was trying to actually help.

@ArsenShnurkov
Copy link

I support the point of alanmcgovern.
@dougrathbone you can add the dependencies as nuget packages or as git submodules

@dougrathbone
Copy link
Author

Great to see that neither of you after 2 years wants to even accept that there is a bug. Even though i'd taken the time to jump through hoops to prove it to you. First I raised it, then you challenged me to prove it with a test. Then I did so, and then you complained about the format of my submission because it included dependencies.

The only thing that's quite clear is that you don't want to fix the actual root problem. Which is a real shame as others would hopefully focus on the task at hand - the bug that breaks key generation.

@ArsenShnurkov
Copy link

I have no commit right for this repository. What I will do - will fork from some other who enabled issues, and continue from there.
https://github.com/Schumix/ngit
looks good for my purposes from the first sight

@dougrathbone
Copy link
Author

Thank you - the main issue I have is that I can't get the solution to even build without the dependencies i've included. Not sure if you're building on a *nix box or not, but VS wouldn't build the SLN as-is, and nuget's version of some of the mono dependencies are different versions to those reffed.

Let me know if you need help looking into it further or if you want to jump on chat.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants