[nuget] use $(PackageLicenseExpression), not $(PackageLicenseUrl) #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#licenseurl
Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#license
Context: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/nuget#important-nuget-package-metadata
Context: https://docs.clearlydefined.io/curation-guidelines
Certain internal Microsoft tools check NuGet license information by
using ClearlyDefined curated data to determine verified license
information for packages which don't "clearly define" their license.
Unfortunately, a license URL is not considered "clearly defined",
likely because it isn't really machine readable. (Just because the
URL contains "MIT" doesn't mean it's actually MIT.)
As part of this effort, NuGet deprecated the
<licenseUrl/>
element, and MSBuild deprecated the
$(PackageLicenseUrl)
MSBuild property. The NuGet
<license/>
element or$(PackageLicenseExpression)
MSBuild property should be used.Replace
$(PackageLicenseUrl)
with$(PackageLicenseExpression)
,with a value of
MIT AND BSD-3-Clause
. The value needs to be anSPDX identifier, and as OpenTK contains both MIT and 3-clause
BSD license text within
Documentation/Licennse.txt
, using theAND
expression feels appropriate.This change should satisfy ClearlyDefined.