Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-screen rendering and ganesh backend support #24

Closed
kekekeks opened this issue Feb 25, 2016 · 3 comments
Closed

On-screen rendering and ganesh backend support #24

kekekeks opened this issue Feb 25, 2016 · 3 comments

Comments

@kekekeks
Copy link
Contributor

Do you plan to add hardware acceleration support? I have some native code for win/linux/ios/android that we use in Perspex for hw-accelerated drawing using Skia. For Windows it will add dependency on ANGLE, but performance improvements are worth of adding such dependency.

@kekekeks
Copy link
Contributor Author

Since opengl-related calls are too platform-specific and complex for the end-user it's better to keep Garesh backend initialization and surface-flipping in the native lib. I also can see that currently your bindings don't have built-in on-screen rendering support and you leave the task of blitting image to screen to the user.

In Perspex we have a concept of a render target that allows to create a rendering session which, when disposed, is flipped back to screen. It may be worth to do the same.

interface IRenderTarget
{
     IRenderingContext CreateContext();
}


interface IRenderingContext : IDisposable
{
      SkCanvas Canvas { get; }
}

To end user it will look like this:

var target = new OSWindowRenderTarget(hWnd/xid/nswindow);
...

using(var ctx = target.CreateContext())
{
     ctx.Canvas.DrawRectangle(...);
}

That render target will manage everything required to initialize ganesh-backend using ANGLE/EGL/GLX/AGLX/whatever or fall back to sw rendering.

Currently we have in Perspex:

iOS render target using GLKView

OS window abstraction with sw/hw rendering switch with backends for

EGL/ANGLE hw-accel backend for Win/Linux/Android

That code provides a simple C++ API:

class RenderingContext
{
public:
    SkCanvas* Canvas;
    virtual ~RenderingContext() {}
};

class RenderTarget
{
public:
    virtual RenderingContext* CreateRenderingContext() = 0;
    virtual ~RenderTarget() {}
};

Code is MIT-licensed and could be easily ported if you agree with the design.

@mattleibow
Copy link
Contributor

@kekekeks I will be looking into this soon. I have got most of the GPU bits building for all platforms right now. The next step is to get ANGLE for Windows added, then wrap all the necessary types.

As the GPU bits are building already, initial wrapper can be created for OpenGL right now, except the UWP will have to wait for ANGLE. Win32 can have initial GL support until ANGLE arrives - giving it more options for devs.

@mattleibow
Copy link
Contributor

@kekekeks Hardware support is here (-ish)
I have started with getting all the bits together and I think it is working quite well. Right now All the platforms should have OpenGL support (DirectX is coming in a few). This means all the platforms, except UWP, can draw with hardware acceleration.

The global issue for hardware / GPU is here: #138
Please leave comments and suggestions so we can get the best product out.

There is also a preview NuGet: https://www.nuget.org/packages/SkiaSharp/1.53.2-gpu1
Please try that out and be sure to comment on how it went - if there are any features needed, just let us know!

@mattleibow mattleibow added this to To Be Classified in Previous Releases Jul 26, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Previous Releases
To Be Classified
Development

No branches or pull requests

3 participants