Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed canvas double drawing and made BackgroundColor virtual #1037

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixed canvas double drawing and made BackgroundColor virtual #1037

wants to merge 3 commits into from

Conversation

mykyta-bondarenko
Copy link

No description provided.

@msftclas
Copy link

msftclas commented May 13, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@mykyta-bondarenko @sevoku
added a comment to CanvasBackend BG prop overriding
6a7b1d0 
Co-authored-by: Vsevolod Kukol <sevoku@microsoft.com>
sevoku
sevoku requested changes May 15, 2020
View reviewed changes
Copy link
Member

@sevoku sevoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed that with @slluis, we should not make public API virtual. We need to think about alternatives.

@mykyta-bondarenko
Copy link
Author

@sevoku we can keep it as it's but use new word to make a workaround in vsm code

@mykyta-bondarenko mykyta-bondarenko deleted the fix/canvas-drawing branch July 3, 2020 14:19
@sevoku sevoku restored the fix/canvas-drawing branch October 6, 2020 13:19
@sevoku
Copy link
Member

sevoku commented Oct 6, 2020

Reopening, we still need to fix this.

@sevoku sevoku reopened this Oct 6, 2020
Base automatically changed from master to main March 9, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevoku sevoku sevoku requested changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mykyta-bondarenko @msftclas @sevoku