[Mac] NSView based tables #714
Conversation
|
|
||
| public override void MouseEntered (NSEvent theEvent) | ||
| { | ||
| this.HandleMouseEntered (theEvent); |
There was a problem hiding this comment.
Shouldn't this be checked like the others?
There was a problem hiding this comment.
do you mean whther it has been handled? The entered/exited events have no arguments and can't be interrupted: https://github.com/mono/xwt/blob/master/Xwt/Xwt.Backends/ICellViewFrontend.cs#L49-L50, hence no need to check here.
| public override void MouseDown (NSEvent theEvent) | ||
| { | ||
| if (!this.HandleMouseDown (theEvent)) | ||
| base.MouseDown (theEvent); |
|
|
||
| public override void MouseExited (NSEvent theEvent) | ||
| { | ||
| this.HandleMouseExited (theEvent); |
There was a problem hiding this comment.
Shouldn't this be checked like the others?
|
|
||
| public override void MouseDragged (NSEvent theEvent) | ||
| { | ||
| if (!this.HandleMouseMoved (theEvent)) |
There was a problem hiding this comment.
No, HandleMouseMoved is right, we have no dragging support (not implemented and disabled) and dragging won't fire the MouseMoved event. We do the same for normal widgets here: https://github.com/mono/xwt/blob/master/Xwt.XamMac/Xwt.Mac/WidgetView.cs#L172-L181
There was a problem hiding this comment.
As in, shouldn't this return bool?
There was a problem hiding this comment.
sry, can you explain what you mean exactly? Its an override void and the base is called only if the handler returns false. The other handlers (MouseEntered/MouseExited) have no event args in Xwt and therefore there is no need to check whether they return true/false, the base method will always be called there.
There was a problem hiding this comment.
Okay, I now understand why it's like this. 👍
| c.Fill (); | ||
| } | ||
|
|
||
| var s = CellSize; | ||
| foreach (var c in GetCells (new CGRect (new CGPoint (0, 0), Frame.Size))) { |
| int nexpands = 0; | ||
| double requiredSize = 0; | ||
| double availableSize = cellFrame.Width; | ||
| var sizes = new Dictionary<ICellRenderer, double> (); |
There was a problem hiding this comment.
Sizes used to be a dictionary due to having to access by ICellRenderer later on. Can't this be a simple list? Is a cell reusable?
There was a problem hiding this comment.
Hhm, yeah, this could be optimized, I just copied the old code.
Notify the RowDeleted listener of deleted rows in reverse order, to make it easier to sync indexes with internal lists.
sevoku
force-pushed
the
mac-nsview-based-tables
branch
from
dd80b2c
to
1c43f37
Compare
|
It looks good overall. That's a big change, a thorough review will take time... |
| var container = Table.GetView (cellBackend.Column, row, false) as CompositeCell; | ||
| if (container != null) { | ||
| var cellView = container.GetCellViewForBackend (cellBackend); | ||
| rect = cellView.ConvertRectToView (new CoreGraphics.CGRect (new CoreGraphics.CGPoint (0, 0), cellView.Frame.Size), Table).ToXwtRect (); |
This PR replaces the deprecated NSCell based table/cell implementation with the recommended NSView based table mode.
Features: