Add --add-sources option #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mono0926
reviewed
Mar 1, 2022
Comment on lines
9
to
16
| public let source: String? | ||
|
|
||
| public init(name: String, nameSpecified: String?, version: String?) { | ||
| self.name = name | ||
| self.nameSpecified = nameSpecified | ||
| self.version = version | ||
| self.source = "https://cocoapods.org/pods/\(name)" | ||
| } |
There was a problem hiding this comment.
How about this?
Suggested change
| public let source: String? | |
| public init(name: String, nameSpecified: String?, version: String?) { | |
| self.name = name | |
| self.nameSpecified = nameSpecified | |
| self.version = version | |
| self.source = "https://cocoapods.org/pods/\(name)" | |
| } | |
| public var source: String? { "https://cocoapods.org/pods/\(name)" } |
This is a common point in other public let source: String? line.
There was a problem hiding this comment.
Seems good, then we can drop the custom initializer.
mono0926
approved these changes
Mar 1, 2022
|
Thanks, released now: https://github.com/mono0926/LicensePlist/releases/tag/3.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
--add-sourcesoption that adds the source to the generated output. Defaults tofalse.ownerandname