Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a license type to each license.plist #183

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Add a license type to each license.plist #183

merged 1 commit into from
Apr 1, 2022

Conversation

AF-cgi
Copy link

@AF-cgi AF-cgi commented Mar 31, 2022

Add the type of license as LicenseType to each generated license plist file. If you use CocoaPods then the license is defined within the podspec. If you use SPM, the license will fetched for each package by using the Github API.

@AF-cgi
Copy link
Author

AF-cgi commented Mar 31, 2022

@mono0926 I don't know why the test fails. Locally all tests are succeeded. Can you double check? I have run the test with Xcode 13.2.1 and 13.3.

@mono0926
Copy link
Owner

mono0926 commented Apr 1, 2022

@AF-cgi

Also failed on my environment(Xcode 13.3) 🤔

image

@AF-cgi
Copy link
Author

AF-cgi commented Apr 1, 2022

@mono0926 Let me check again.

@AF-cgi
Copy link
Author

AF-cgi commented Apr 1, 2022

@mono0926 done

@mono0926 mono0926 merged commit 2c45cd9 into mono0926:main Apr 1, 2022
@mono0926
Copy link
Owner

mono0926 commented Apr 1, 2022

@AF-cgi AF-cgi deleted the feature/license-type branch April 1, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants