Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes out of bounds access if package.swift cannot be parsed #193

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

stmitt
Copy link
Contributor

@stmitt stmitt commented Jul 29, 2022

No description provided.

@mono0926 mono0926 merged commit 2889c52 into mono0926:main Jul 31, 2022
@mono0926
Copy link
Owner

@bennokress
Copy link
Contributor

bennokress commented Jul 31, 2022

There's an error in this PR (which is why all the V2 naming tests are red)! I'm currently on vacation so I can't fix it, but looking at the changes in this PR: index [1] is obviously not .first, so now we're probably always using the fallback name again (parsing from the Github URL). A possible solution woud be to use the Array Extension at the end of the file .element(at: 1) and guarding that !startingPoint.isEmpty afterwards or writing another extension that returns nil if the element at that index doesn't exist.

Otherwise: good catch, I missed that when implementing the new V2 naming solution 👍🏼

mono0926 added a commit that referenced this pull request Aug 1, 2022
mono0926 added a commit that referenced this pull request Aug 1, 2022
@mono0926
Copy link
Owner

mono0926 commented Aug 1, 2022

@bennokress

Sorry, I missed 🙏

Thanks, I've fixed it and released: #195, https://github.com/mono0926/LicensePlist/releases/tag/3.22.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants