Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(yaml): replace yaml parser library to support multi new line #218

Merged
merged 6 commits into from
Jun 16, 2023
Merged

feature(yaml): replace yaml parser library to support multi new line #218

merged 6 commits into from
Jun 16, 2023

Conversation

RyuNen344
Copy link
Contributor

@RyuNen344 RyuNen344 commented Jun 13, 2023 •
edited
Loading

YamlSwift can't parse yaml like below

manual:
  - source: https://github.com/firebase/firebase-ios-sdk
    name: Firebase
    version: 4.0.0
    body: |2
                                      Apache License
                                Version 2.0, January 2004
                              http://www.apache.org/licenses/
        TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

so I replaced yaml parser Library, YamlSwift to Yams

RyuNen344
RyuNen344 commented Jun 13, 2023
View reviewed changes
Tests/LicensePlistTests/Entity/ConfigTests.swift
@@ -17,6 +17,10 @@ class ConfigTests: XCTestCase {
source: "https://webrtc.googlesource.com/src",
nameSpecified: "Web RTC",
version: "M61"),
Manual(name: "Firebase",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails until this PR merge

RyuNen344
RyuNen344 commented Jun 13, 2023
View reviewed changes
Tests/LicensePlistTests/Entity/SwiftPackageManagerTests.swift
repositoryURL: "https://github.com/behrang/YamlSwift.git",
revision: "287f5cab7da0d92eb947b5fd8151b203ae04a9a3",
version: "3.4.4",
XCTAssertEqual(packageLast, SwiftPackage(package: "yams",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this test fails until this PR merge

@RyuNen344 RyuNen344 marked this pull request as draft June 14, 2023 04:42
@RyuNen344 RyuNen344 marked this pull request as ready for review June 14, 2023 06:06
@RyuNen344
Copy link
Contributor Author

Thanks for allowing to run GitHub Actions, I will fix lint indicates

@RyuNen344
Copy link
Contributor Author

I fixed issues.

@RyuNen344
Copy link
Contributor Author 

/home/runner/work/LicensePlist/LicensePlist/Sources/LicensePlistCore/Entity/Manual.swift:45:1: error: Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
/home/runner/work/LicensePlist/LicensePlist/Sources/LicensePlistCore/Entity/Manual.swift:50:1: error: Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
/home/runner/work/LicensePlist/LicensePlist/Sources/LicensePlistCore/Entity/Manual.swift:55:1: error: Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

sorry, I will refix..... 😢

@RyuNen344
Copy link
Contributor Author

I fixed lint error, Could you approve to run GitHub Actions?

@mono0926 mono0926 merged commit d6c152c into mono0926:main Jun 16, 2023
1 of 2 checks passed
@mono0926
Copy link
Owner

@RyuNen344

Thanks, released 👍
https://github.com/mono0926/LicensePlist/releases/tag/3.24.10

@RyuNen344 RyuNen344 deleted the feature/support-multi-new-line branch June 16, 2023 07:02
@Porkepix Porkepix mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyuNen344 @mono0926