Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unnecessary references of files in Xcode #29

Merged
merged 1 commit into from May 8, 2017
Merged

Delete unnecessary references of files in Xcode #29

merged 1 commit into from May 8, 2017

Conversation

pixyzehn
Copy link

@pixyzehn pixyzehn commented May 8, 2017

[nits]
I found unnecessary references of files in Xcode like this. I'm not sure these are needed or not. Please check my deletions.
I deleted 3 files references in this PR and already checked build and tests are passed.

screen shot 2017-05-08 at 17 41 24

@mono0926 mono0926 merged commit a1e6176 into mono0926:master May 8, 2017
@pixyzehn pixyzehn deleted the delete-unnecessary-references-in-xcode branch May 8, 2017 08:51
@mono0926
Copy link
Owner

mono0926 commented May 8, 2017

Thanks, those are ignored, but it seems that swift package generate-xcodeproj picked up them…
I'll be careful that.

@pixyzehn
Copy link
Author

pixyzehn commented May 8, 2017

Thank you for checking!

It may be better to add *.xcodeproj in the .gitignore file like https://github.com/apple/swift-package-manager/blob/master/.gitignore#L10 because I have a lot of differences when executing swift package generate-xcodeproj.
For development, we can develop like this https://github.com/apple/swift-package-manager/blob/master/Documentation/Development.md#developing-using-xcode.

It's just my idea, please introduce them if you like👍

@pixyzehn
Copy link
Author

pixyzehn commented May 8, 2017

#30
Thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants