Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showConfirmationDialog height #5

Closed
xJon opened this issue Jun 18, 2020 · 3 comments
Closed

showConfirmationDialog height #5

xJon opened this issue Jun 18, 2020 · 3 comments

Comments

@xJon
Copy link

xJon commented Jun 18, 2020

Hi,
Is there any way while using showConfirmationDialog to have a more "responsive" height?
The widget works well when the list is long enough to be scrollable, and I am aware of contentMaxHeight which I am using currently, but it's not ideal.

Maybe you could add an option to pass to the widget's ListView a shrinkWrap value, so one could set it to true.

Thanks!

@mono0926
Copy link
Owner

@xJon

Thanks for the feedback.
Your opinion is reasonable, so I added shrinkWrap to showConfirmationDialog, and released 0.7.4:
https://pub.dev/packages/adaptive_dialog#074

@xJon
Copy link
Author

xJon commented Jun 19, 2020

Thank you! Is it also possible to control the ListView's physics: NeverScrollableScrollPhysics(), to make it more usable for non-scrollable, shorter dialogs?

mono0926 added a commit that referenced this issue Jun 19, 2020
… to `showConfirmationDialog`'s inner `ListView`

- #5 (comment)
@mono0926
Copy link
Owner

Is it also possible to control the ListView's physics: NeverScrollableScrollPhysics(), to make it more usable for non-scrollable, shorter dialogs?

Supported at 0.7.5 👌 :
https://pub.dev/packages/adaptive_dialog#075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants