Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All generated plist files contain 404 not found #58

Closed
funkenstrahlen opened this issue Jun 2, 2017 · 13 comments
Closed

All generated plist files contain 404 not found #58

funkenstrahlen opened this issue Jun 2, 2017 · 13 comments
Assignees

Comments

@funkenstrahlen
Copy link

funkenstrahlen commented Jun 2, 2017

I use the current version 1.4.5.

I generate using license-plist. It does find all the use pods as it created all the .plist files e.g. Alamofire.plist.

However all these pod plist files which should include the licenses just include 404 not found.

I tried to fix it by using a github token, but this was not the issue and did not help. Any ideas?

(Yes I have a working internet connection and I can see the license file of alamofire in my browser without any problem)

@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

@funkenstrahlen

For Pods, I don't use GitHub API, and I use the license bodies contained in XXX-acknowledgements.plist files like this.

screen shot 2017-06-02 at 17 29 55

So, I suspect that XXX-acknowledgements.plist contains 404 not found and if so, it's CocoaPods' problem.

Could you check XXX-acknowledgements.plist files?

@funkenstrahlen
Copy link
Author

funkenstrahlen commented Jun 2, 2017

I did check on that file. It's named Pods-Bookshelf-acknowledgements.plist in my case and it does contain a plist of all the licences of my pods and does not have 404 inside.

When I run license-plist also my com.mono0926.LicensePlist.plist contains 404 not found. So not only pod specific files are getting 404 but also the main collection list.

@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

@funkenstrahlen

For Carthage(Cartfile), I use GitHub API. Do you use it?

And, could you paste console logs?

@funkenstrahlen
Copy link
Author

funkenstrahlen commented Jun 2, 2017

I do not use a Cartfile.

license-plist --force
[2017-06-02T10:14:21.116+02:00] [INFO] Start
[2017-06-02T10:14:21.130+02:00] [INFO] Pod acknowledgements found: Pods-Bookshelf-acknowledgements.plist
[2017-06-02T10:14:21.130+02:00] [INFO] Pod acknowledgements found: Pods-BookshelfTests-acknowledgements.plist
[2017-06-02T10:14:21.130+02:00] [INFO] Pod acknowledgements found: Pods-BookshelfUITests-acknowledgements.plist
[2017-06-02T10:14:21.131+02:00] [INFO] Pods License parse start
[2017-06-02T10:14:21.143+02:00] [WARNING] Not found: Cartfile.resolved -- file:///Users/funkenstrahlen/Projects/bookshelf-ios-app/.
[2017-06-02T10:14:21.143+02:00] [WARNING] Not found: Cartfile -- file:///Users/funkenstrahlen/Projects/bookshelf-ios-app/.
[2017-06-02T10:14:21.143+02:00] [INFO] Carthage License collect start
[2017-06-02T10:14:21.146+02:00] [INFO] Deleted exiting plist within com.mono0926.LicensePlist
[2017-06-02T10:14:21.147+02:00] [INFO] Directory created: com.mono0926.LicensePlist.Output/ -- file:///Users/funkenstrahlen/Projects/bookshelf-ios-app/
[2017-06-02T10:14:21.767+02:00] [INFO] End
[2017-06-02T10:14:21.768+02:00] [INFO] ----------Result-----------
[2017-06-02T10:14:21.768+02:00] [INFO] # Missing license:
[2017-06-02T10:14:21.768+02:00] [INFO] None🎉

This looks fine in my eyes.

@funkenstrahlen funkenstrahlen changed the title All generated plist files containt 404 not found All generated plist files contain 404 not found Jun 2, 2017
@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

@funkenstrahlen

Did you check all of these three acknowledgements.plist files?

[2017-06-02T10:14:21.130+02:00] [INFO] Pod acknowledgements found: Pods-Bookshelf-acknowledgements.plist
[2017-06-02T10:14:21.130+02:00] [INFO] Pod acknowledgements found: Pods-BookshelfTests-acknowledgements.plist
[2017-06-02T10:14:21.130+02:00] [INFO] Pod acknowledgements found: Pods-BookshelfUITests-acknowledgements.plist

If you can, could you send me those acknowledgements.plist files?

And I'd like to confirm com.mono0926.LicensePlist.latest_result.txt, which is a result summary.

@funkenstrahlen
Copy link
Author

Alle the files you requested: https://gist.github.com/3c7fd3795b6ece7071d6e122746e57dd

@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

@funkenstrahlen

Thanks, but it seems to be okay.
https://gist.github.com/funkenstrahlen/3c7fd3795b6ece7071d6e122746e57dd#file-com-mono0926-licenseplist-latest_result-txt-L2 body is not 404.

And, I generated plist license files by using your acknowledgements.plist files. The result was fine.

I'd like to confirm your generated files, which include 404 not found

@funkenstrahlen
Copy link
Author

funkenstrahlen commented Jun 2, 2017

I'd like to confirm your generated files, which include 404 not found

I do not know what I can do to help you in this case. They are completely empty except of 404: Not Found.

@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

@funkenstrahlen

Umm, I cannot reproduce the problem, so it is difficult to fix it...

I do not know what I can do to help you in this case. They are completely empty except of 404: Not Found.

Just in case, I'd like to check the generated file like https://gist.github.com/3c7fd3795b6ece7071d6e122746e57dd .

@funkenstrahlen
Copy link
Author

@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

@funkenstrahlen

Thanks.
Plist body is generated like this:

let item = ["PreferenceSpecifiers": [["Type": "PSGroupSpecifier", "FooterText": license.body]]]
let value = try! PropertyListSerialization.data(fromPropertyList: item, format: .xml, options: 0)

So, I cannot believe 404: Not Found was written.

Expected result example:
https://gist.github.com/mono0926/6ef64d97a43004eeab7d8bb94ed01fa0

I'm sorry, but I cannot fix it now.
I'll fix when I now the reason.

@mono0926 mono0926 self-assigned this Jun 2, 2017
@funkenstrahlen
Copy link
Author

I just completely removed license-plist and reinstalled it via homebrew. Now it works perfectly. Still do not know what was wrong but looks like this was a weird bug in my installation...

Thank you for you quick response and help though!

@mono0926
Copy link
Owner

mono0926 commented Jun 2, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants