fails to build with JUCE-7.0.2

[umlaeute]

i tried to upgrade JUCE to JUCE-7.0.2 and experienced build failures (as expected, as AudioPlayHead::getCurrentPosition() has been deprecated in JUCE-7.0.0)

here's a naive attempt to fix the build:

--- giada.orig/src/core/plugins/pluginHost.cpp
+++ giada/src/core/plugins/pluginHost.cpp
@@ -49,14 +49,15 @@
 
 /* -------------------------------------------------------------------------- */
 
-bool PluginHost::Info::getCurrentPosition(CurrentPositionInfo& result)
+juce::Optional<juce::AudioPlayHead::PositionInfo> PluginHost::Info::getPosition() const
 {
-	result.bpm           = m_sequencer.getBpm();
-	result.timeInSamples = m_sequencer.getCurrentFrame();
-	result.timeInSeconds = m_sequencer.getCurrentSecond(m_sampleRate);
-	result.isPlaying     = m_sequencer.isRunning();
+	juce::Optional<juce::AudioPlayHead::PositionInfo> info;
+	info->setBpm           (m_sequencer.getBpm());
+	info->setTimeInSamples (m_sequencer.getCurrentFrame());
+	info->setTimeInSeconds (m_sequencer.getCurrentSecond(m_sampleRate));
+	info->setIsPlaying     (m_sequencer.isRunning());
 
-	return true;
+	return info;
 }
 
 /* -------------------------------------------------------------------------- */
--- giada.orig/src/core/plugins/pluginHost.h
+++ giada/src/core/plugins/pluginHost.h
@@ -60,7 +60,7 @@
 	public:
 		Info(const Sequencer&, int sampleRate);
 
-		bool getCurrentPosition(CurrentPositionInfo& result) override;
+		juce::Optional<PositionInfo> getPosition() const override;
 		bool canControlTransport() override;
 
 	private:

[gvnnz]

Hi @umlaeute , we fixed those issues when we upgraded to JUCE 7 here: 42f1beb. Still not officially released though.

[umlaeute]

since 0.24.0 is out (and the relevant commit was already in 0.23.0), i guess this issue can be closed.