Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement seeking #32

Closed
swenner opened this issue Jun 12, 2010 · 7 comments
Closed

Implement seeking #32

swenner opened this issue Jun 12, 2010 · 7 comments

Comments

@swenner
Copy link
Contributor

swenner commented Jun 12, 2010

Implement seeking in a track.

@monodeldiablo
Copy link
Owner

Seeking is already implemented, front end and back end. Right now, though, I think you have to use both mouse buttons to seek to a particular spot.

@swenner
Copy link
Contributor Author

swenner commented Jun 13, 2010

Ok it works. But why do I have to use both mouse buttons?
I expect such behaviour from an application like Blender. But IMHO Hum should behave like other applications in the GNOME ecosystem.

@monodeldiablo
Copy link
Owner

Technically, that is the default behavior in GNOME. The issue with one-button seeking is that the slider is continuously updating as the track progresses. Because the logic to handle a click event takes slightly longer than the track progress update timeout, the progress update clobbers the click event and the seek is ignored. If you look at the handle_slider_moved() method in hum_gui.vala, you can see what I'm talking about.

I'm working on getting this to work right now.

@monodeldiablo
Copy link
Owner

Ignore that. Sorry. I already fixed the bug I referenced above. The real issue seems to be that the Gtk.Adjustment that's associated with the slider doesn't have its increments set appropriately. I'm committing a fix for that now. Thanks again for this bug!

@monodeldiablo
Copy link
Owner

  • Implement single-click seeking. [closed by 99b6f96]

@swenner
Copy link
Contributor Author

swenner commented Jun 13, 2010

It works. Thanks.
But it would be nice if it would behave like in Totem. If I click on the slider it should immediately jump to this position in the track.

@monodeldiablo
Copy link
Owner

Ok. I think Totem and Rhythmbox hack the default behavior of Gtk.Scale objects to accomplish that behavior. I'll see what I can do. :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants