Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a gitlab handler #17

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Added a gitlab handler #17

merged 2 commits into from
Jun 24, 2020

Conversation

gmponos
Copy link
Member

@gmponos gmponos commented Jun 22, 2020

closes #9

@gmponos gmponos added the new handler Implement a new http handler label Jun 22, 2020
@gmponos gmponos requested a review from savvasal June 22, 2020 20:16
savvasal
savvasal reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@savvasal savvasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding the fingerprint field as optional?

@gmponos
Copy link
Member Author

gmponos commented Jun 24, 2020

@savvasal done.

@savvasal savvasal self-requested a review June 24, 2020 09:35
@gmponos gmponos merged commit c513ba2 into master Jun 24, 2020
@gmponos gmponos deleted the add-gitlab-handler branch July 6, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savvasal savvasal savvasal approved these changes

Assignees
No one assigned
Labels
new handler Implement a new http handler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gitlab handler
2 participants
@gmponos @savvasal